[POWERPC] start-cpu has no return code

According to this document:

 PowerPC Processor binding to: IEEE 1275-1994
 Standard for Boot (Initialization, Configuration) Firmware
 Revision: 2.1 (Approved Version)
 Date: November 6, 1996

The start-cpu client interface has the following signature:

 start-cpu
  IN: nodeid, pc, arg
  OUT: none

This patch reflects that, and makes us stop seeing a bogus OF_FAILURE if
we do actually check the return code of of_start_cpu.  Tested on JS20
and JS21 blades.

Signed-off-by: Amos Waterland <apw@us.ibm.com>
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff --git a/xen/arch/powerpc/boot_of.c b/xen/arch/powerpc/boot_of.c
index a450b7de9a2e18ef55204e5a521a9155d96aa5f6..57465e7bc0345af253327952fb0f41e67eb1bd0e 100644 (file)
--- a/xen/arch/powerpc/boot_of.c
+++ b/xen/arch/powerpc/boot_of.c
@@ -304,12 +304,11 @@ static int __init of_instance_to_path(int ih, char *buffer, u32 buflen)
 
 static int __init of_start_cpu(int cpu, u32 pc, u32 reg)
 {
-    int rets[1] = { OF_FAILURE };
+    int ret;
 
-    if ( of_call("start-cpu", 3, 0, rets, cpu, pc, reg) == OF_FAILURE )
-        return OF_FAILURE;
+    ret = of_call("start-cpu", 3, 0, NULL, cpu, pc, reg);
 
-    return rets[0];
+    return ret;
 }
 
 static void __init of_test(const char *of_method_name)